Re: [PATCH 05/20] arm64: dts: marvell: Prepare the introduction of AP807 based SoCs
From: Gregory CLEMENT <gregory.clement@bootlin.com>
Date: 2019-08-27 15:20:55
Also in:
linux-devicetree
Hi Miquel,
quoted hunk ↗ jump to hunk
From: Konstantin Porotchkin <redacted> Prepare the support for Marvell AP807 die. This die is very similar to AP806 but uses different DDR PHY. AP807 is a major component of CN9130 SoC series. Signed-off-by: Konstantin Porotchkin <redacted> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 448 +---------------- arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 456 ++++++++++++++++++ 2 files changed, 458 insertions(+), 446 deletions(-) create mode 100644 arch/arm64/boot/dts/marvell/armada-ap80x.dtsidiff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi index a23ddd46efc5..cdadb28f287e 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi@@ -5,454 +5,10 @@ * Device Tree file for Marvell Armada AP806. */ -#include <dt-bindings/interrupt-controller/arm-gic.h> -#include <dt-bindings/thermal/thermal.h> - -/dts-v1/; +#define AP_NAME ap806
I didn't find where AP_NAME is used.
+#include "armada-ap80x.dtsi"
[...]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi new file mode 100644 index 000000000000..c44cd7c64bf6 --- /dev/null +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
[...]
+ ap806 {This file will be used for ap806 and for ap807 but the ap name will be the same for both varirant? Shouldn't you use the AP_NAME here? Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel