Thread (18 messages) 18 messages, 3 authors, 2019-08-02

Re: [RFC 6/9] dt-bindings: phy: meson-g12a-usb2-phy: convert to yaml

From: Rob Herring <robh+dt@kernel.org>
Date: 2019-08-01 15:07:31
Also in: linux-amlogic, linux-devicetree

On Thu, Aug 1, 2019 at 7:56 AM Neil Armstrong [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Neil Armstrong <redacted>
---
 .../bindings/phy/meson-g12a-usb2-phy.txt      | 22 ------
 .../bindings/phy/meson-g12a-usb2-phy.yaml     | 67 +++++++++++++++++++
 2 files changed, 67 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt
 create mode 100644 Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.yaml
diff --git a/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt b/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt
deleted file mode 100644
index a6ebc3dea159..000000000000
--- a/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-* Amlogic G12A USB2 PHY binding
-
-Required properties:
-- compatible:  Should be "amlogic,meson-g12a-usb2-phy"
-- reg:         The base address and length of the registers
-- #phys-cells: must be 0 (see phy-bindings.txt in this directory)
-- clocks:      a phandle to the clock of this PHY
-- clock-names: must be "xtal"
-- resets:      a phandle to the reset line of this PHY
-- reset-names: must be "phy"
-- phy-supply:  see phy-bindings.txt in this directory
-
-Example:
-       usb2_phy0: phy@36000 {
-               compatible = "amlogic,g12a-usb2-phy";
-               reg = <0x0 0x36000 0x0 0x2000>;
-               clocks = <&xtal>;
-               clock-names = "xtal";
-               resets = <&reset RESET_USB_PHY21>;
-               reset-names = "phy";
-               #phy-cells = <0>;
-       };
diff --git a/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.yaml
new file mode 100644
index 000000000000..4cd5ba97d469
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2019 BayLibre, SAS
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/phy/meson-g12a-usb2-phy.yaml#"
For this and the filename, use the compatible string (i.e. add 'amlogic,').
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Amlogic G12A USB2 PHY
+
+maintainers:
+  - Neil Armstrong [off-list ref]
+
+properties:
+  compatible:
+    enum:
+      - amlogic,meson-g12a-usb2-phy
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+    description:
+      A phandle to the clock of this PHY
As mentioned elsewhere, this description can be dropped.
+
+  clock-names:
+    items:
+      - const: xtal
+
+  resets:
+    maxItems: 1
+    description:
+      A phandle to the reset line of this PHY
+
+  reset-names:
+    items:
+      - const: phy
+
+  "#phy-cells":
+    const: 0
+
+  phy-supply:
+     maxItems: 1
+     description:
+       Phandle to a regulator that provides power to the PHY. This
+       regulator will be managed during the PHY power on/off sequence.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+  - "#phy-cells"
phy-supply was required in the old doc though the example disagrees.
If dropping required is desired, just mention so in the commit
message.
+
+examples:
+  - |
+    phy@36000 {
+          compatible = "amlogic,meson-g12a-usb2-phy";
+          reg = <0x36000 0x2000>;
+          clocks = <&xtal>;
+          clock-names = "xtal";
+          resets = <&phy_reset>;
+          reset-names = "phy";
+          #phy-cells = <0>;
+    };
--
2.22.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help