Thread (33 messages) 33 messages, 4 authors, 2019-09-03

RE: [PATCH 4/7] iommu/arm-smmu: Add global/context fault implementation hooks

From: Krishna Reddy <vdumpa@nvidia.com>
Date: 2019-08-30 17:48:56
Also in: linux-iommu, linux-tegra, lkml

quoted
+	if (smmu->impl->global_fault)
+		return smmu->impl->global_fault(irq, smmu);
Can't we just register impl->global_fault (if set) instead of arm_smmu_global_fault as the handler when we first set up the IRQs in arm_smmu_device_probe()?
Ideally we'd do the same for the context banks as well, although we might need an additional hook from which to request the secondary IRQs that the main flow can't accommodate.
When first implemented theis patch, I think there were compile issues in accessing struct arm_smmu_domain from arm-smmu-nvidia.c as it was part of arm-smmu.c. 
To avoid issues accessing arm_smmu_domain. It did this for context fault and did same for global fault for uniformity.
Now, I see that it is part of arm-smmu.h.  Let me update code to register implementation hooks directly.  Thanks

-KR

 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help