On 8/27/2019 9:00 PM, Andrew Murray wrote:

On Mon, Aug 26, 2019 at 01:01:40PM +0530, Vidya Sagar wrote:

quoted

Add support to configure sideband signal pins when information is present
in respective controller's device-tree node.

Signed-off-by: Vidya Sagar <redacted>
---
  drivers/pci/controller/dwc/pcie-tegra194.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index fc0dbeb31d78..8a27b25893c9 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c

@@ -1308,6 +1308,12 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)
  		return ret;
  	}
  
+	ret = pinctrl_pm_select_default_state(pcie->dev);
+	if (ret < 0) {
+		dev_err(pcie->dev, "Failed to configure sideband pins\n");

I think you can just use dev instead of pcie->dev here.

Yup. I can use just 'dev' here.

quoted

+		return ret;

Don't you need to pm_runtime_put_sync and pm_runtime_disable here?

Yup. Thanks for catching it. I'll address it in next patch series.

Thanks,

Andrew Murray

quoted

+	}
+
  	tegra_pcie_init_controller(pcie);
  
  	pcie->link_state = tegra_pcie_dw_link_up(&pcie->pci);
-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel