Re: [PATCH v1 1/1] ARM: dts: rockchip: set crypto default disabled on rk3288
From: Heiko Stuebner <heiko@sntech.de>
Date: 2019-08-27 14:28:40
Also in:
linux-devicetree, linux-rockchip, lkml
Hi, Am Dienstag, 27. August 2019, 09:14:39 CEST schrieb Elon Zhang:
Not every board needs to enable crypto node, so the node should be set default disabled in rk3288.dtsi and enabled in specific board dts file.
Can you give a bit more rationale here? There would need to be a very specific reason because of the following: The crypto module is not wired to some board-specific components, so its usability does not depend on the specific board at all. Instead every board can just use it out of the box and the devicetree is supposed to describe the hardware and is _not_ meant as a space for user configuration. So in fact the status property should probably go away completely from the crypto node, as it's usable out of the box in all cases. Heiko
quoted hunk ↗ jump to hunk
Signed-off-by: Elon Zhang <redacted> --- arch/arm/boot/dts/rk3288.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index cc893e154fe5..d509aa24177c 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi@@ -984,7 +984,7 @@ clock-names = "aclk", "hclk", "sclk", "apb_pclk"; resets = <&cru SRST_CRYPTO>; reset-names = "crypto-rst"; - status = "okay"; + status = "disabled"; }; iep_mmu: iommu@ff900800 {
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel