Hello Rob,

Thank you for the review.

On 8/22/2019 12:18 AM, Rob Herring wrote:

On Fri, Aug 09, 2019 at 11:29:14AM +0000, Stefan-gabriel Mirea wrote:

quoted

+* Freescale Linflex UART

Be consistent with the name: LINFlexD?

This was also brought up in our internal review. However, the reference
manual is also inconsistent, using LINFlexD, LINflexD, LinFlexD,
LINFlex, LINFLEX, LinFlex and Linflex. I will switch to 'LINFlexD'
everywhere, though.

quoted

+The LINFlexD controller implements several LIN protocol versions, as well as
+support for full-duplex UART communication through 8-bit and 9-bit frames. The
+Linflex UART driver enables operation only in UART mode.

What the driver supports or not is independent of the binding.

Ok, I will remove the last sentence ("The Linflex UART driver enables
operation only in UART mode").

quoted

+  - "fsl,s32-linflexuart" for linflex configured in uart mode which

LINFlexD?

Will fix; I agree that the all lowercase version has no occurrence in
the reference manual.

quoted

+  is compatible with the one integrated on S32V234 SoC

Compatibles should be SoC specific. Is 's32' specific enough to account
for any differences or future bugs found?

It is probably not. I will change it to "fsl,s32v234-linflexuart" (as
well as in the device tree and driver).

quoted

+Example:
+uart0:serial@40053000 {

space    ^

quoted

+     compatible = "fsl,s32-linflexuart";
+     reg = <0x0 0x40053000 0x0 0x1000>;
+     interrupts = <0 59 4>;
+     status = "disabled";

Don't show status in examples.

Will fix these too.

Regards,
Stefan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel