Re: [PATCH v5 1/2] dt-bindings: mmc: Document Aspeed SD controller

On Thu, 22 Aug 2019, at 21:15, Ulf Hansson wrote:

On Thu, 15 Aug 2019 at 07:37, Andrew Jeffery [off-list ref] wrote:

quoted

On Thu, 15 Aug 2019, at 15:06, Joel Stanley wrote:

quoted

On Wed, 7 Aug 2019 at 00:38, Andrew Jeffery [off-list ref] wrote:

quoted

The ASPEED SD/SDIO/MMC controller exposes two slots implementing the
SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit
data bus if only a single slot is enabled.

Signed-off-by: Andrew Jeffery <redacted>

Reviewed-by: Joel Stanley <joel@jms.id.au>

Two minor comments below.

quoted

+++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml

@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: GPL-2.0-or-later

No "Copyright IBM" ?

I'm going rogue.

That reminds me I should chase up where we got to with the binding
licensing.

quoted

quoted

+%YAML 1.2
+---

quoted

+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    sdc@1e740000 {
+            compatible = "aspeed,ast2500-sd-controller";
+            reg = <0x1e740000 0x100>;
+            #address-cells = <1>;
+            #size-cells = <1>;
+            ranges = <0 0x1e740000 0x10000>;

According to the datasheet this could be 0x20000. It does not matter
though, as there's nothing in it past 0x300.

Good catch.

Are you planning on sending a v6 or you want me to apply this and you
can post a patch on top?

Yeah, sorry, I wasn't very clear there. I was hoping just to do a follow-up
patch with the cleanups if you're okay with that?

Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel