RE: perf tool issue following 'perf stat: Fix --no-scale' patch integration

Hello Arnaldo and Andi

Indeed, 'aligned(8)' instead of 'aligned(64)'.
Thanks for your quick feedbacks and I am going to prepare the patch.

Gérald
 

Em Wed, Aug 21, 2019 at 09:26:35AM -0700, Andi Kleen escreveu:

quoted

quoted

   +             char contents[] __attribute__((aligned(64)));

I think you want aligned(8). The parameter is bytes, not bits.

quoted

   But the xyarray structure is generic so I think this patch cannot be the
   final one.

I think it's fine actually to just apply this generically (with 8). It
will only waste a few bytes on other 32bit architectures and should be
a nop on 64bit, not worth doing anything more sophisticated.

I would just submit a patch to do that.

Agreed.

- Arnaldo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel