Re: [PATCH 2/2] net: gmii2rgmii: Switch priv field in mdio device structure
From: Andrew Lunn <andrew@lunn.ch>
Date: 2019-08-13 15:38:29
Also in:
lkml, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: 2019-08-13 15:38:29
Also in:
lkml, netdev
quoted
The kernel does have a few helper, spi_get_drvdata, pci_get_drvdata, hci_get_drvdata. So maybe had add phydev_get_drvdata(struct phy_device *phydev)?Maybe phydev_mdio_get_drvdata? Because the driver data member available is phydev->mdio.dev.driver_data.
I still prefer phydev_get_drvdata(). It fits with the X_get_drvdata() pattern, where X is the type of parameter passed to the call, spi, pci, hci. We can also add mdiodev_get_drvdata(mdiodev). A few DSA drivers could use that. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel