Re: [PATCH v5 01/10] dt-bindings: add powercontroller
From: Lee Jones <hidden>
Date: 2019-08-12 15:15:28
Also in:
linux-devicetree, linux-mediatek, linux-pm, linux-rtc, lkml
On Mon, 12 Aug 2019, Frank Wunderlich wrote:
quoted hunk ↗ jump to hunk
From: Josef Friedl <redacted> add mt6323-rtc and mt6323-pwrc to mt6397 mfd DT bindings an example is shown in mt6323-poweroff.txt Suggested-by: Frank Wunderlich <redacted> Signed-off-by: Josef Friedl <redacted> Signed-off-by: Frank Wunderlich <redacted> Acked-for-MFD-by: Lee Jones [off-list ref] --- changes since v4: use relative path changes since v3: none changes since v2: separated rtc-mt6397.txt to part 2 --- .../devicetree/bindings/mfd/mt6397.txt | 20 +++++++++++++------ .../bindings/power/reset/mt6323-poweroff.txt | 20 +++++++++++++++++++ 2 files changed, 34 insertions(+), 6 deletions(-) create mode 100644 Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txtdiff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 0ebd08af777d..063f5fe1cace 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt@@ -8,11 +8,12 @@ MT6397/MT6323 is a multifunction device with the following sub modules: - Clock - LED - Keys +- Power controller It is interfaced to host controller using SPI interface by a proprietary hardware called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. See the following for pwarp node definitions: -Documentation/devicetree/bindings/soc/mediatek/pwrap.txt +../../bindings/soc/mediatek/pwrap.txt This document describes the binding for MFD device and its sub module.@@ -22,14 +23,16 @@ compatible: "mediatek,mt6397" or "mediatek,mt6323" Optional subnodes: - rtc - Required properties: + Required properties: Should be one of follows + - compatible: "mediatek,mt6323-rtc" - compatible: "mediatek,mt6397-rtc" + For details, see ../../bindings/rtc/rtc-mt6397.txt
Apologies for the ambiguity. I don't think you need to go all the way back to 'bindings'. Just one step back will do fine. ../rtc/* will be fine here. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel