Re: [PATCH] dt-bindings: clock: imx8mn: Fix tab indentation for yaml file
From: Stephen Boyd <sboyd@kernel.org>
Date: 2019-08-07 23:59:26
Also in:
linux-clk, linux-devicetree, lkml
Subsystem:
kernel build + files below scripts/ (unless maintained elsewhere), open firmware and flattened device tree bindings, the rest · Maintainers:
Nathan Chancellor, Nicolas Schier, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds
Quoting Rob Herring (2019-07-25 14:37:24)
On Thu, Jul 25, 2019 at 3:06 PM Stephen Boyd [off-list ref] wrote:quoted
Quoting Anson.Huang@nxp.com (2019-07-24 19:05:51)quoted
From: Anson Huang <redacted> YAML file can NOT contain tab as indentation, fix it.Would be nice if checkpatch could check for this.Would be nice if folks just ran 'make dt_binding_check'. :) It wouldn't be hard to add a tab check to checkpatch, but that's just one potential problem.
Cool, thanks for the pointer. Seems I forgot :) Here's a patch to improve the documentation and make help to answer questions I had about how to work this into my workflow.
diff --git a/Documentation/devicetree/writing-schema.md b/Documentation/devicetree/writing-schema.md
index dc032db36262..17ad67887fde 100644
--- a/Documentation/devicetree/writing-schema.md
+++ b/Documentation/devicetree/writing-schema.md@@ -120,6 +120,7 @@ This will first run the `dt_binding_check` which generates the processed schema. It is also possible to run checks with a single schema file by setting the 'DT_SCHEMA_FILES' variable to a specific schema file. +`make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml` `make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml`
diff --git a/Makefile b/Makefile
index 9be5834073f8..96bb28aa1c46 100644
--- a/Makefile
+++ b/Makefile@@ -1503,8 +1503,10 @@ help: @echo '' @$(if $(dtstree), \ echo 'Devicetree:'; \ - echo '* dtbs - Build device tree blobs for enabled boards'; \ - echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo '* dtbs - Build device tree blobs for enabled boards'; \ + echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo ' dt_binding_check - Validate device tree binding documents'; \ + echo ' dtbs_check - Validate device tree source files'; \ echo '') @echo 'Userspace tools targets:'
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel