On 03/08/2019 20:50, Martin Blumenstingl wrote:

On Wed, Jul 31, 2019 at 2:44 PM Neil Armstrong [off-list ref] wrote:
[...]

quoted

+       memory@0 {
+               device_type = "memory";
+               reg = <0x0 0x0 0x0 0x40000000>;

nit-pick: we typically use the memory size used in the board size with
the lowest amount of RAM - 2GiB in this case. so I would change it to
0x80000000

Right

[...]

quoted

+       leds {
+               compatible = "gpio-leds";
+
+               white {
+                       label = "vim3:white";

downstream sources use label="sys_led"
should we call it vim3:white:sys?

OK, no problem
Thanks for the review.

Neil

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel