Re: [PATCH v3] clk: imx8mq: Mark AHB clock as critical
From: Shawn Guo <shawnguo@kernel.org>
Date: 2019-08-03 15:04:45
Also in:
linux-clk, lkml
On Tue, Jul 30, 2019 at 10:22:55AM +0300, Abel Vesa wrote:
Initially, the TMU_ROOT clock was marked as critical, which automatically
made the AHB clock to stay always on. Since the TMU_ROOT clock is not
marked as critical anymore, following commit:
431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT")The commit ID is not stable before the commit actually lands mainline. I could possibly rebase the branch.
all the clocks that derive from ipg_root clock (and implicitly ahb clock)
would also have to enable, along with their own gate, the AHB clock.
But considering that AHB is actually a bus that has to be always on, we mark
it as critical in the clock provider driver and then all the clocks that
derive from it can be controlled through the dedicated per IP gate which
follows after the ipg_root clock.
Signed-off-by: Abel Vesa <redacted>
Tested-by: Daniel Baluta <daniel.baluta@nxp.com>
Fixes: 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT")Dropped commit ID above and Fixes tag here, and applied the patch. Thanks for the fixing. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel