Re: [PATCH v3 04/10] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC
From: Hsin-hsiung Wang <hidden>
Date: 2019-08-02 13:28:43
Also in:
linux-devicetree, linux-mediatek, linux-rtc, lkml
Hi Nicolas, On Tue, 2019-05-07 at 14:24 +0900, Nicolas Boichat wrote:
On Fri, May 3, 2019 at 6:34 PM Hsin-Hsiung Wang [off-list ref] wrote:quoted
...
quoted
This adds compatible for the MediaTek MT6358 PMIC. Acked-for-MFD-by: Lee Jones [off-list ref] Signed-off-by: Hsin-Hsiung Wang <redacted> --- Documentation/devicetree/bindings/mfd/mt6397.txt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 0ebd08af777d..62f1c17c7738 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt@@ -17,22 +17,27 @@ Documentation/devicetree/bindings/soc/mediatek/pwrap.txt This document describes the binding for MFD device and its sub module. Required properties: -compatible: "mediatek,mt6397" or "mediatek,mt6323" +compatible: + "mediatek,mt6323" for PMIC MT6323 + "mediatek,mt6358" for PMIC MT6358 + "mediatek,mt6397" for PMIC MT6397 Optional subnodes: - rtc Required properties: - - compatible: "mediatek,mt6397-rtc" + - compatible: "mediatek,mt6397-rtc" or "mediatek,mt6358-rtc" - regulators Required properties: - compatible: "mediatek,mt6397-regulator" see Documentation/devicetree/bindings/regulator/mt6397-regulator.txt + - compatible: "mediatek,mt6358-regulator" + see Documentation/devicetree/bindings/regulator/mt6358-regulator.txt - compatible: "mediatek,mt6323-regulator" see Documentation/devicetree/bindings/regulator/mt6323-regulator.txt - codec Required properties: - - compatible: "mediatek,mt6397-codec" + - compatible: "mediatek,mt6397-codec" or "mediatek,mt6358-sound"Sean had a question about this (https://patchwork.kernel.org/patch/10846669/#22524299): "why didn't we use a more consistent naming as mt6358-codec?"
The compatible name, "mediatek,mt6358-sound", is already in mt6358 audio driver which is already in the upstream codebase. After discussing with audio owner, we will submit another patch to fix it. Thanks.
quoted
- clk Required properties: - compatible: "mediatek,mt6397-clk" -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel