Re: [PATCH] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib
From: Uwe Kleine-König <hidden>
Date: 2019-08-01 14:47:19
Also in:
linux-serial, lkml
On Thu, Aug 01, 2019 at 12:46:42PM +0000, Schrempf Frieder wrote:
From: Frieder Schrempf <redacted> If CONFIG_GPIOLIB is not enabled, mctrl_gpio_init() and mctrl_gpio_init_noauto() will currently return an error pointer with -ENOSYS. As the mctrl GPIOs are usually optional, drivers need to check for this condition to allow continue probing. To avoid the need for this check in each driver, we return NULL instead, as all the mctrl_gpio_*() functions are skipped anyway. We also adapt mctrl_gpio_to_gpiod() to be in line with this change. Signed-off-by: Frieder Schrempf <redacted> --- drivers/tty/serial/serial_mctrl_gpio.c | 3 +++ drivers/tty/serial/serial_mctrl_gpio.h | 6 +++--- drivers/tty/serial/sh-sci.c | 2 +-
I'd split the sh-sci change in a separate patch. And there is another instance in drivers/tty/serial/8250/8250_core.c that should be dropped. Other than that looks good. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel