Re: [PATCH] mtd: rawnand: meson: Add of_node_put() before return
From: Liang Yang <liang.yang@amlogic.com>
Date: 2019-07-18 03:58:27
Also in:
linux-amlogic
Hi Nishka, On 2019/7/10 1:16, Nishka Dasgupta wrote:
quoted hunk ↗ jump to hunk
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <redacted> --- drivers/mtd/nand/raw/meson_nand.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index ea57ddcec41e..1b82b687e5a5 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c@@ -1320,6 +1320,7 @@ static int meson_nfc_nand_chips_init(struct device *dev, ret = meson_nfc_nand_chip_init(dev, nfc, nand_np); if (ret) { meson_nfc_nand_chip_cleanup(nfc); + of_node_put(nand_np);
Thank you. Looks good to me: Acked-by: Liang Yang <liang.yang@amlogic.com>
return ret; } }
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel