Re: [PATCH v2 1/2] ARM: dts: rockchip: move rk3288-veryon display settings into a separate file
From: Doug Anderson <dianders@chromium.org>
Date: 2019-07-24 21:19:35
Also in:
linux-devicetree, linux-rockchip
Hi, On Thu, Jul 11, 2019 at 3:35 PM Matthias Kaehlcke [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/rk3288-veyron-edp.dtsi b/arch/arm/boot/dts/rk3288-veyron-edp.dtsi new file mode 100644 index 000000000000..5d812e9e78aa --- /dev/null +++ b/arch/arm/boot/dts/rk3288-veyron-edp.dtsi@@ -0,0 +1,124 @@ +// SPDX-License-Identifier: GPL-2.0
Please allow MIT license: // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+&pinctrl {
+ backlight {
+ bl_en: bl-en {
+ rockchip,pins = <7 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};nit: convention on Rockchip device tree files is that all pinctrl stuff is at the bottom. Downstream I think I added comments about this but those didn't make it upstream. Also: why did you move "bl_en" here but not "edp_hpd"? -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel