On Mon, Jul 01, 2019 at 11:03:51AM +0100, Steven Price wrote:

On 01/07/2019 10:27, Will Deacon wrote:

quoted

On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote:

quoted

walk_page_range() is going to be allowed to walk page tables other than
those of user space. For this it needs to know when it has reached a
'leaf' entry in the page tables. This information will be provided by the
p?d_large() functions/macros.

I can't remember whether or not I asked this before, but why not call
this macro p?d_leaf() if that's what it's identifying? "Large" and "huge"
are usually synonymous, so I find this naming needlessly confusing based
on this patch in isolation.

You replied to my posting of this patch before[1], to which you said:

quoted

I've have thought p?d_leaf() might match better with your description
above, but I'm not going to quibble on naming.

That explains the sense of deja vu.

Have you changed your mind about quibbling? ;)

Ha, I suppose I have! If it's not loads of effort to use p?d_leaf() instead
of p?d_large, then I'd certainly prefer that.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel