On 7/2/19 2:03 PM, Linus Walleij wrote:

Hi Florian!

thanks for your patch!

On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli [off-list ref] wrote:

quoted

From: Abbott Liu <redacted>

The purpose of this patch is to provide set_ttbr0/get_ttbr0 to
kasan_init function. The definitions of cp15 registers should be in
arch/arm/include/asm/cp15.h rather than arch/arm/include/asm/kvm_hyp.h,
so move them.

Cc: Andrey Ryabinin <redacted>
Reported-by: Marc Zyngier <redacted>
Signed-off-by: Abbott Liu <redacted>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

quoted

+#include <linux/stringify.h>

What is this for? I think it can be dropped.

Indeed, that can be dropped came from an earlier version of the patch.

This stuff adding a whole bunch of accessors:

quoted

+static inline void set_par(u64 val)
+{
+       if (IS_ENABLED(CONFIG_ARM_LPAE))
+               write_sysreg(val, PAR_64);
+       else
+               write_sysreg(val, PAR_32);
+}

Can we put that in a separate patch since it is not
adding any users, so this is a pure refactoring patch for
the current code?

Sure, that makes sense, first move all definitions, then add helper
functions, finally make use of them.
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel