Re: [PATCH 00/12] treewide: Fix GENMASK misuses
From: Joe Perches <joe@perches.com>
Date: 2019-07-10 16:01:36
Also in:
alsa-devel, dri-devel, linux-amlogic, linux-aspeed, linux-iio, linux-media, linux-mediatek, linux-mmc, linux-wireless, lkml, netdev, openbmc
On Wed, 2019-07-10 at 08:45 -0700, Joe Perches wrote:
On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote:quoted
On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote:quoted
On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote:quoted
These GENMASK uses are inverted argument order and the actual masks produced are incorrect. Fix them. Add checkpatch tests to help avoid more misuses too. Joe Perches (12): checkpatch: Add GENMASK testsIMHO this doesn't make a lot of sense as a checkpatch test - just throw in a BUILD_BUG_ON()?I tried that. It'd can't be done as it's used in declarations and included in asm files and it uses the UL() macro. I also tried just making it do the right thing whatever the argument order.
I forgot. I also made all those arguments when it was introduced in 2013. https://lore.kernel.org/patchwork/patch/414248/
Oh well.
yeah. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel