Re: [PATCH v2] spi/acpi: enumerate all SPI slaves in the namespace
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2019-06-03 11:08:46
Also in:
linux-acpi, linux-spi
On Thu, May 30, 2019 at 01:16:34PM +0200, Ard Biesheuvel wrote:
quoted hunk ↗ jump to hunk
@@ -1948,7 +1988,8 @@ static void acpi_register_spi_devices(struct spi_controller *ctlr) if (!handle) return; - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1, + status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
Would it be simpler to differentiate here between Apple and non-Apple systems? Then we don't need all that special code and the above becomes: depth = x86_apple_system ? 1 : SPI_ACPI_ENUMERATE_MAX_DEPTH; status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT, depth, .. Probably requires a comment explaining why we do it like that, though. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel