Re: [PATCH] clk: Add clk_parent entry in debugfs
From: Stephen Boyd <sboyd@kernel.org>
Date: 2019-06-07 19:05:24
Also in:
linux-clk
Quoting Leonard Crestez (2019-05-24 01:25:25)
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index aa51756fd4d6..94a93b07dd37 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c@@ -3009,10 +3009,21 @@ static int possible_parents_show(struct seq_file *s, void *data) return 0; } DEFINE_SHOW_ATTRIBUTE(possible_parents); +static int current_parent_show(struct seq_file *s, void *data) +{ + struct clk_core *core = s->private; + + if (core->parent) + seq_printf(s, "%s\n", core->parent->name); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(current_parent);
Looks OK.
quoted hunk ↗ jump to hunk
+ static int clk_duty_cycle_show(struct seq_file *s, void *data) { struct clk_core *core = s->private; struct clk_duty *duty = &core->duty;@@ -3040,10 +3051,11 @@ static void clk_debug_create_one(struct clk_core *core, struct dentry *pdentry) debugfs_create_u32("clk_enable_count", 0444, root, &core->enable_count); debugfs_create_u32("clk_protect_count", 0444, root, &core->protect_count); debugfs_create_u32("clk_notifier_count", 0444, root, &core->notifier_count); debugfs_create_file("clk_duty_cycle", 0444, root, core, &clk_duty_cycle_fops); + debugfs_create_file("clk_parent", 0444, root, core, ¤t_parent_fops);
Shouldn't we skip creation of this file if core->num_parents == 0? So put this under the if condition below?
if (core->num_parents > 1)
debugfs_create_file("clk_possible_parents", 0444, root, core,
&possible_parents_fops);
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel