Thread (21 messages) 21 messages, 5 authors, 2019-07-09

Re: [PATCH v3 1/9] pinctrl: sunxi: v3s: introduce support for V3

From: Linus Walleij <hidden>
Date: 2019-06-25 13:57:31
Also in: linux-clk, linux-devicetree, linux-gpio, lkml

On Mon, Jun 24, 2019 at 2:40 PM Maxime Ripard [off-list ref] wrote:
On Sun, Jun 23, 2019 at 12:37:53PM +0800, Icenowy Zheng wrote:
quoted
Introduce the GPIO pins that is only available on V3 (not on V3s) to the
V3s pinctrl driver.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
Changes in v3:
- Fixed code alignment.
- Fixed LVDS function number.
quoted
-               SUNXI_FUNCTION(0x2, "uart2"),         /* TX */
-               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)),  /* PB_EINT0 */
+               SUNXI_FUNCTION(0x2, "uart2"),                 /* TX */
+               SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)),          /* PB_EINT0 */
I'm not sure why all that churn is needed.

Looks good otherwise.
Should I apply the patch or wait for a new version without the
whitespace fixes?

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help