Thread (15 messages) 15 messages, 3 authors, 2019-06-17

Re: [PATCH v8 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function

From: Nicolas Boichat <hidden>
Date: 2019-06-14 08:31:40
Also in: linux-devicetree, linux-mediatek, lkml

On Wed, Jun 12, 2019 at 4:53 PM Bibby Hsieh [off-list ref] wrote:
quoted hunk ↗ jump to hunk
GCE cannot know the register base address, this function
can help cmdq client to get the cmdq_client_reg structure.

Signed-off-by: Bibby Hsieh <redacted>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c | 24 ++++++++++++++++++++++++
 include/linux/soc/mediatek/mtk-cmdq.h  | 20 ++++++++++++++++++++
 2 files changed, 44 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 70ad4d806fac..fac4d33fd520 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -27,6 +27,30 @@ struct cmdq_instruction {
        u8 op;
 };

+int cmdq_dev_get_client_reg(struct device *dev,
+                           struct cmdq_client_reg *client_reg, int idx)
+{
+       struct of_phandle_args spec;
+
+       if (!client_reg)
+               return -EINVAL;
+
+       if (of_parse_phandle_with_args(dev->of_node, "mediatek,gce-client-reg",
+                                      "#subsys-cells", idx, &spec)) {
+               dev_err(dev, "can't parse gce-client-reg property (%d)", idx);
+
+               return -EINVAL;
+       }
+
+       client_reg->subsys = spec.args[0];
+       client_reg->offset = spec.args[1];
+       client_reg->size = spec.args[2];
+       of_node_put(spec.np);
+
+       return 0;
+}
+EXPORT_SYMBOL(cmdq_dev_get_client_reg);
+
 static void cmdq_client_timeout(struct timer_list *t)
 {
        struct cmdq_client *client = from_timer(client, t, timer);
diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h
index a345870a6d10..2e2a2274c231 100644
--- a/include/linux/soc/mediatek/mtk-cmdq.h
+++ b/include/linux/soc/mediatek/mtk-cmdq.h
@@ -15,6 +15,12 @@

 struct cmdq_pkt;

+struct cmdq_client_reg {
+       u8 subsys;
+       u16 offset;
+       u16 size;
+};
+
 struct cmdq_client {
        spinlock_t lock;
        u32 pkt_cnt;
@@ -142,4 +148,18 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb,
  */
 int cmdq_pkt_flush(struct cmdq_pkt *pkt);

+/**
+ * cmdq_dev_get_client_reg() - parse cmdq client reg from the device node of CMDQ client
Minor nit: this line is over 80 chars.
+ * @dev:       device of CMDQ mailbox clienti
+ * @client_reg: CMDQ client reg pointer
+ * @idx:       the index of desired reg
+ *
+ * Return: 0 for success; else the error code is returned
+ *
+ * Help CMDQ client pasing the cmdq client reg
+ * from the device node of CMDQ client.
+ */
+int cmdq_dev_get_client_reg(struct device *dev,
+                           struct cmdq_client_reg *client_reg, int idx);
+
 #endif /* __MTK_CMDQ_H__ */
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help