Re: [PATCH][next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret

From
Nicolas.Ferre@microchip.com
Date
2019-06-12 07:55:37
Also in
dri-devel, kernel-janitors, linux-fbdev, lkml
Reply to
Colin King, 2019-06-11
On 11/06/2019 at 19:09, Colin King wrote:
External E-Mail


From: Colin Ian King <redacted>

Currently variable ret is being initialized with -ENOENT however that
value is never read and ret is being re-assigned later on. Hence this
assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
Indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks, best regards,
   Nicolas

quoted hunk ↗ jump to hunk
---
  drivers/video/fbdev/atmel_lcdfb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
index fb117ccbeab3..930cc3f92e01 100644
--- a/drivers/video/fbdev/atmel_lcdfb.c
+++ b/drivers/video/fbdev/atmel_lcdfb.c
@@ -950,7 +950,7 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
  	struct fb_videomode fb_vm;
  	struct gpio_desc *gpiod;
  	struct videomode vm;
-	int ret = -ENOENT;
+	int ret;
  	int i;
  
  	sinfo->config = (struct atmel_lcdfb_config*)

-- 
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (4 messages) 4 messages, 4 authors, last reply 2019-06-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help