Re: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN
From: Shawn Guo <shawnguo@kernel.org>
Date: 2019-06-12 06:06:11
Also in:
linux-devicetree, linux-gpio, lkml
On Tue, Jun 11, 2019 at 10:00:36AM +0000, Aisheng Dong wrote:
quoted
From: Linus Walleij [mailto:linus.walleij@linaro.org] Sent: Saturday, June 8, 2019 5:04 AM On Thu, May 30, 2019 at 5:04 AM [off-list ref] wrote:quoted
From: Anson Huang <redacted> Add binding doc for i.MX8MN pinctrl driver. Signed-off-by: Anson Huang <redacted>Looks mostly OK to me, but I'd like the maintainers to review, so Dong et al please look at this!quoted
+Required properties: +- compatible: "fsl,imx8mn-iomuxc"So should this not be "nxp,imx8mn-iomuxc" or "nxp,freescale-imx8mn-iomuxc" or something these days? The vendor name is nxp is it not. I was complaining to the DT maintainers at one point that these companies seem to buy each other left and right so this vendor nomenclature is dubious, but I guess at least it should reflect the vendor that produced the chip or something. If everyone is happy with "fsl,*" I will not complain though. (i.e. if the maintainers ACK it.)We preferred to keep "fsl,*" for Freescale i.MX product line according to last discussion. And we already did this way for most i.MX devices.
+1 We do not see serious problem with 'fsl' prefix, so would rather stay with it. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel