Re: [PATCH 1/7] perf: arm64: Compile tests unconditionally
From: Mark Rutland <mark.rutland@arm.com>
Date: 2019-06-11 17:01:32
Also in:
lkml
On Tue, Jun 11, 2019 at 11:23:56AM -0300, Arnaldo Carvalho de Melo wrote:
Em Tue, Jun 11, 2019 at 03:09:07PM +0100, Mark Rutland escreveu:quoted
On Tue, Jun 11, 2019 at 01:53:09PM +0100, Raphael Gault wrote:quoted
In order to subsequently add more tests for the arm64 architecture we compile the tests target for arm64 systematically.Given prior questions regarding this commit, it's probably worth spelling things out more explicitly, e.g. Currently we only build the arm64/tests directory if CONFIG_DWARF_UNWIND is selected, which is fine as the only test we have is arm64/tests/dwarf-unwind.o. So that we can add more tests to the test directory, let's unconditionally build the directory, but conditionally build dwarf-unwind.o depending on CONFIG_DWARF_UNWIND. There should be no functional change as a result of this patch.quoted
Signed-off-by: Raphael Gault <redacted>Either way, the patch looks good to me: Acked-by: Mark Rutland <mark.rutland@arm.com>I'll update the comment, collect your Acked-by and apply the patch.
That's great, thanks! As a heads-up, there are still open ABI discussions to be had on the rest of the series, so while review would be appreciated, it would be best to hold off applying the remaining userspace bits for now. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel