Thread (13 messages) 13 messages, 2 authors, 2019-06-05

Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610

From: Vinod Koul <vkoul@kernel.org>
Date: 2019-06-04 12:36:41
Also in: dmaengine, linux-devicetree, lkml

On 29-05-19, 17:08, yibin.gong@nxp.com wrote:
quoted hunk ↗ jump to hunk
@@ -205,8 +228,9 @@ static int fsl_edma_probe(struct platform_device *pdev)
 	if (!fsl_edma)
 		return -ENOMEM;
 
-	fsl_edma->version = v1;
-	fsl_edma->dmamux_nr = DMAMUX_NR;
+	fsl_edma->drvdata = drvdata;
+	fsl_edma->version = drvdata->version;
+	fsl_edma->dmamux_nr = drvdata->dmamuxs;
And can we avoid the duplication here, you have version and dmamuxs
represented in two places. But right now it looks logical so the removal
should be done after this series

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help