-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: 2019年5月24日 20:29
To: Chuanhua Han <redacted>
Cc: Leo Li <redacted>; Shawn Guo <shawnguo@kernel.org>;
mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
[off-list ref]
Subject: Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node

Caution: EXT Email

On Fri, May 24, 2019 at 4:48 AM Chuanhua Han [off-list ref]
wrote:

quoted

Hi, Rob Herring

quoted

-----Original Message-----
From: Leo Li
Sent: 2019年5月22日 14:50

quoted

quoted

quoted

quoted

quoted

quoted

quoted

quoted

quoted

-             wdog0: watchdog@23c0000 {
-                     compatible = "fsl,ls1028a-wdt",

"fsl,imx21-wdt";

quoted

quoted

quoted

quoted

quoted

-                     reg = <0x0 0x23c0000 0x0 0x10000>;
-                     interrupts = <GIC_SPI 59

IRQ_TYPE_LEVEL_HIGH>;

quoted

quoted

quoted

-                     clocks = <&clockgen 4 1>;
-                     big-endian;
-                     status = "disabled";
+             cluster1_core0_watchdog: wdt@c000000 {

Keep 'watchdog' as the node name,

Thanks for your replay
Do you mean replace the ‘wdt’ with ‘watchdog’?
and keep nodes sort in unit-address.
What does this mean?

That means order the nodes by the addresses (e.g. c000000,
c010000)

The current order is correct（The first is c000000, then c000000）.

But they are added after gpio@2320000 and before sata@3200000.

I changed and made the second version of the patch, but I found
the following error when I executed ./scripts/checkpatch.pl
xxx.patch to check the patch:

WARNING: DT compatible string vendor "arm" appears un-documented
-- check ./Documentation/devicetree/bindings/vendor-prefixes.txt
#43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
+ compatible = "arm,sp805", "arm,primecell";

However, there is no vendor-prefixes.txt file in the
./Documentation/devicetree/bindings/ directory, only vendor-
prefixes.yaml.
Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.

Added Rob Herring to the thread.

quoted

Request help，thanks

How can I solve this patch check error? Ask for help, thank you!

Ignore it. A fix to checkpatch.pl is pending.

OK, the second version has been sent. Checking with checkpatch.pl is no problem.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel