Re: [PATCH v6 04/12] dt-binding: gce: add binding for gce event property
From: Rob Herring <robh@kernel.org>
Date: 2019-05-24 21:54:11
Also in:
linux-devicetree, linux-mediatek, lkml
On Thu, May 16, 2019 at 05:02:16PM +0800, Bibby Hsieh wrote:
Client hardware would send event to GCE hardware, mediatek,gce-event-names and mediatek,gce-events
We removed mediatek,gce-event-names?
quoted hunk ↗ jump to hunk
can be used to present the event. Signed-off-by: Bibby Hsieh <redacted> --- Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt index dceab63ccd06..265bb58da7bd 100644 --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt@@ -35,6 +35,8 @@ Required properties for a client device: Optional properties for a client device: - mediatek,gce-client-reg: u32, specify the sub-system id which is corresponding to the register address. +- mediatek,gce-events: u32, the event number defined in + 'dt-bindings/gce/mt8173-gce.h' or 'dt-binding/gce/mt8183-gce.h'.
This and the example don't match. Is it an u32 or an array of u32? If the latter, how many elements?
quoted hunk ↗ jump to hunk
Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h' or 'dt-binding/gce/mt8183-gce.h'. Such as sub-system ids, thread priority, event ids.@@ -57,8 +59,8 @@ Example for a client device: compatible = "mediatek,mt8173-mmsys"; mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; - mutex-event-eof = <CMDQ_EVENT_MUTEX0_STREAM_EOF - CMDQ_EVENT_MUTEX1_STREAM_EOF>; + mediatek,gce-events = <CMDQ_EVENT_MDP_RDMA0_SOF>, + <CMDQ_EVENT_MDP_RSZ0_SOF>; mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>, <&gce SUBSYS_1401XXXX 0x2000 0x100>; ...-- 2.18.0
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel