Re: [PATCH V7 13/15] phy: tegra: Add PCIe PIPE2UPHY support
From: Thierry Reding <hidden>
Date: 2019-05-21 11:00:58
Also in:
linux-devicetree, linux-pci, linux-tegra, lkml
On Fri, May 17, 2019 at 06:08:44PM +0530, Vidya Sagar wrote:
quoted hunk ↗ jump to hunk
Synopsys DesignWare core based PCIe controllers in Tegra 194 SoC interface with Universal PHY (UPHY) module through a PIPE2UPHY (P2U) module. For each PCIe lane of a controller, there is a P2U unit instantiated at hardware level. This driver provides support for the programming required for each P2U that is going to be used for a PCIe controller. Signed-off-by: Vidya Sagar <redacted> --- Changes since [v6]: * None Changes since [v5]: * Addressed review comments from Thierry Changes since [v4]: * None Changes since [v3]: * Rebased on top of linux-next top of the tree Changes since [v2]: * Replaced spaces with tabs in Kconfig file * Sorted header file inclusion alphabetically Changes since [v1]: * Added COMPILE_TEST in Kconfig * Removed empty phy_ops implementations * Modified code according to DT documentation file modifications drivers/phy/tegra/Kconfig | 7 ++ drivers/phy/tegra/Makefile | 1 + drivers/phy/tegra/pcie-p2u-tegra194.c | 109 ++++++++++++++++++++++++++ 3 files changed, 117 insertions(+) create mode 100644 drivers/phy/tegra/pcie-p2u-tegra194.cdiff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig index a3b1de953fb7..06d423fa85b4 100644 --- a/drivers/phy/tegra/Kconfig +++ b/drivers/phy/tegra/Kconfig@@ -6,3 +6,10 @@ config PHY_TEGRA_XUSB To compile this driver as a module, choose M here: the module will be called phy-tegra-xusb. + +config PHY_TEGRA194_PCIE_P2U + tristate "NVIDIA Tegra P2U PHY Driver"
One more thing: perhaps make this description consistent with the driver description in the source file. Thierry