Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
flat view
From: Vinod Koul <vkoul@kernel.org>
Date: 2019-05-21 05:12:55
Also in:
dmaengine, linux-devicetree, linux-spi, lkml
On 21-05-19, 04:58, Robin Gong wrote:
quoted
-----Original Message----- From: Vinod Koul <vkoul@kernel.org> Sent: 2019年5月21日 12:18 On 07-05-19, 09:16, Robin Gong wrote:quoted
Because the number of ecspi1 rx event on i.mx8mm is 0, the condition check ignore such special case without dma channel enabled, which caused ecspi1 rx works failed. Actually, no need to check event_id0, checking event_id1 is enough for DEV_2_DEV case because it's so lucky that event_id1 never be 0.Well is that by chance or design that event_id1 will be never 0?That's by chance. DEV_2_DEV is just for Audio case and non-zero for event_id1 on current i.MX family.
Then it wont be fgood to rely on chance :) -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel