Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header
flat view
From: Bjorn Andersson <hidden>
Date: 2019-05-21 03:06:49
Also in:
linux-arm-msm, lkml, netdev
On Mon 20 May 19:30 PDT 2019, Alex Elder wrote:
On 5/20/19 8:32 PM, Subash Abhinov Kasiviswanathan wrote:quoted
quoted
If you are telling me that the command/data flag resides at bit 7 of the first byte, I will update the field masks in a later patch in this series to reflect that.Higher order bit is Command / Data.So what this means is that to get the command/data bit we use: first_byte & 0x80 If that is correct I will remove this patch from the series and will update the subsequent patches so bit 7 is the command bit, bit 6 is reserved, and bits 0-5 are the pad length. I will post a v2 of the series with these changes, and will incorporate Bjorn's "Reviewed-by".
But didn't you say that your testing show that the current bit order is wrong? I still like the cleanup, if nothing else just to clarify and clearly document the actual content of this header. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel