Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes

On 07.05.2019 00:25, Petr Štetiar wrote:

Hi,

this patch series is an attempt to fix the mess, I've somehow managed to
introduce.

First patch in this series is defacto v5 of the previous 05/10 patch in the
series, but since the v4 of this 05/10 patch wasn't picked up by the
patchwork for some unknown reason, this patch wasn't applied with the other
9 patches in the series, so I'm resending it as a separate patch of this
fixup series again.

Second patch is a result of this rebase against net-next tree, where I was
checking again all current users of of_get_mac_address and found out, that
there's new one in DSA, so I've converted this user to the new ERR_PTR
encoded error value as well.

Third patch which was sent as v5 wasn't considered for merge, but I still
think, that we need to check for possible NULL value, thus current IS_ERR
check isn't sufficient and we need to use IS_ERR_OR_NULL instead.

Fourth patch fixes warning reported by kbuild test robot.

Cheers,

Petr

Petr Štetiar (4):
   net: ethernet: support of_get_mac_address new ERR_PTR error
   net: dsa: support of_get_mac_address new ERR_PTR error
   staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check
   net: usb: smsc: fix warning reported by kbuild test robot

  drivers/net/ethernet/freescale/fec_main.c             | 2 +-

This fixes netboot on imx (probably all of them).

Tested-by: Leonard Crestez <redacted>

But shouldn't "support of_get_mac_address new ERR_PTR error" somehow be 
reordered so that it's done before allowing non-null errors from 
of_get_mac_address?

Otherwise it will break bisect for many people.

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel