On Tue, Mar 26, 2019 at 03:29:03PM +0000, Suzuki K Poulose wrote:

On 03/25/2019 09:56 PM, Mathieu Poirier wrote:

quoted

Refactoring function tmc_etr_setup_perf_buf() so that it only deals
with the high level etr_perf_buffer, and leaving the allocation of the
backend buffer (i.e etr_buf) to another function.

That way the backend buffer allocation function can decide if it wants
to reuse an existing buffer (CPU-wide trace scenarios) or simply create
a new one.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Looks good to me, except for one minor nit:

quoted

---
  .../hwtracing/coresight/coresight-tmc-etr.c   | 46 +++++++++++++------
  1 file changed, 31 insertions(+), 15 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
index 6e2c2aa130d5..79fee9341446 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c

@@ -1159,25 +1159,13 @@ static int tmc_enable_etr_sink_sysfs(struct coresight_device *csdev)
  	return ret;
  }
-/*
- * tmc_etr_setup_perf_buf: Allocate ETR buffer for use by perf.
- * The size of the hardware buffer is dependent on the size configured
- * via sysfs and the perf ring buffer size. We prefer to allocate the
- * largest possible size, scaling down the size by half until it
- * reaches a minimum limit (1M), beyond which we give up.
- */
-static struct etr_perf_buffer *
-tmc_etr_setup_perf_buf(struct tmc_drvdata *drvdata, int node, int nr_pages,
-		       void **pages, bool snapshot)
+static struct etr_buf *
+tmc_etr_get_etr_buf(struct tmc_drvdata *drvdata, int node,
+		    int nr_pages, void **pages)

nit: The name tmc_etr_get_etr_buf() sounds too generic and has nothing
to do with the perf. It would be good to make it explicit that it is for
perf session.

May be, tmc_etr_perf_get_etr_buf() ? or may be even, simply
get_perf_etr_buf().

I don't have a strong preference here, the latter looks fine to me.

Otherwise,

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Ok

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel