Re: [PATCH] I refer to https://github [dot] com/Linaro/OpenCSD/issues/17.
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Date: 2019-03-19 15:43:46
Good day Solomon, On Tue, 19 Mar 2019 at 09:10, Solomon Tan [off-list ref] wrote:
This patch adds the `OCSD_INSTR_WFI_WFE` case to `tools/perf/util/cs-etm-decoder/cs-etm-decoder.c`.
A changelog should explain "why" you're submitting this patch rather than "what" you are submitting. Here it is to address a compilation problem and as such, the changelog should mention that and have the compilation problem that is being fixed. The title should also be fixed to have the name of the subsystem the file belongs to along with a small summary of what is happening with this patch. Calling "git log --oneline" is a good way to start: mpoirier@xps15:~/work/coresight/kernel-410c$ git log --oneline -5 tools/perf/util/cs-etm-decoder/cs-etm-decoder.c 4484a5164db5 perf tools: Add notion of time to decoding code e783a02e0115 perf tools: Linking PE contextID with perf thread mechanic a12827cd6f0d perf tools: Use traceID aware memory callback API fdb55c0c7c79 perf tools: Mandate using openCSD v0.11.0 5fab7009f83a perf tools: Introduce the concept of trace ID queues Here the title should probably be something like: "perf tools: Add missing case value". Finally please use "get_maintainer.pl" when sending a patch. This will ensure the right people can review your code: mpoirier@xps15:~/work/coresight/kernel-410c$ ./scripts/get_maintainer.pl -f tools/perf/util/cs-etm-decoder/cs-etm-decoder.c Mathieu Poirier [off-list ref] (maintainer:ARM/CORESIGHT FRAMEWORK AND DRIVERS) Suzuki K Poulose [off-list ref] (reviewer:ARM/CORESIGHT FRAMEWORK AND DRIVERS) Peter Zijlstra [off-list ref] (supporter:PERFORMANCE EVENTS SUBSYSTEM) Ingo Molnar [off-list ref] (supporter:PERFORMANCE EVENTS SUBSYSTEM) Arnaldo Carvalho de Melo [off-list ref] (supporter:PERFORMANCE EVENTS SUBSYSTEM) Alexander Shishkin [off-list ref] (reviewer:PERFORMANCE EVENTS SUBSYSTEM) Jiri Olsa [off-list ref] (reviewer:PERFORMANCE EVENTS SUBSYSTEM) Namhyung Kim [off-list ref] (reviewer:PERFORMANCE EVENTS SUBSYSTEM) linux-arm-kernel@lists.infradead.org (moderated list:ARM/CORESIGHT FRAMEWORK AND DRIVERS) linux-kernel@vger.kernel.org (open list:PERFORMANCE EVENTS SUBSYSTEM) Please see below for another comment.
quoted hunk
Signed-off-by: solomon-ubuntu <redacted> --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 + 1 file changed, 1 insertion(+)diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index 8c155575c6c5..b5a0ab9403f6 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c@@ -369,6 +369,7 @@ cs_etm_decoder__buffer_range(struct cs_etm_decoder *decoder,switch (elem->last_i_type) { case OCSD_INSTR_BR: + case OCSD_INSTR_WFI_WFE:
Please follow Mike's recommendation on github's thread. I'm waiting for your next revision. Thanks, Mathieu
case OCSD_INSTR_BR_INDIRECT: packet->last_instr_taken_branch = elem->last_instr_exec; break; -- 2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel