Re: [PATCH] drm/stm: ltdc: fix data enable polarity
From: Mukesh Ojha <hidden>
Date: 2019-03-29 21:32:56
Also in:
dri-devel, lkml
On 3/29/2019 9:20 PM, Yannick Fertré wrote:
Wrong DISPLAY_FLAGS used to set the data enable polarity.
Used or checked? Can you also explain how it is wrong to check against this FLAG in commit?
quoted hunk ↗ jump to hunk
Signed-off-by: Yannick Fertré <redacted> --- drivers/gpu/drm/stm/ltdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index b1741a9..6ba326a 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c@@ -555,7 +555,7 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) val |= GCR_VSPOL; - if (vm.flags & DISPLAY_FLAGS_DE_HIGH) + if (vm.flags & DISPLAY_FLAGS_DE_LOW) val |= GCR_DEPOL; if (vm.flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel