Thread (36 messages) 36 messages, 3 authors, 2019-02-27

Re: [RFC PATCH 03/27] mtd: nand: Introduce the ECC engine abstraction

From: Boris Brezillon <boris.brezillon@collabora.com>
Date: 2019-02-27 09:47:24

On Wed, 27 Feb 2019 10:26:42 +0100
Miquel Raynal [off-list ref] wrote:
quoted
  
quoted
+	unsigned int strength;
+	unsigned int step_size;
+	unsigned int total;    
Do we really need to add this total field here? Looks like something
that should be kept private to the ECC engine implementation.  
It was initially private, but I realized it was needed by generic parts
(including for instance the generic OOB layouts) so it could not be
made private.

I just moved the 'total' entry out of the struct nand_ecc_conf and
moved it in the struct nand_ecc_ctx. It is still public but not in the
very generic "conf" structure anymore.
Ack.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help