Thread (7 messages) 7 messages, 3 authors, 2019-02-15

Re: ARM64 boot failure on espressobin with 5.0.0-rc6 (1f947a7a011fcceb14cb912f5481a53b18f1879a)

From: John David Anglin <hidden>
Date: 2019-02-15 16:05:55
Also in: dmaengine, linux-iommu

On 2019-02-14 12:58 p.m., Robin Murphy wrote:
Hmm, having felt brave enough to take a closer look, it might actually be as simple as this - Dave, are you able to give the diff below a spin?

Robin.

----->8-----
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index 7f595355fb79..fe4a7c71fede 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -1059,6 +1059,7 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
         mv_chan->op_in_desc = XOR_MODE_IN_DESC;

     dma_dev = &mv_chan->dmadev;
+    dma_dev->dev = &pdev->dev;
     mv_chan->xordev = xordev;

     /*
@@ -1091,7 +1092,6 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
     dma_dev->device_free_chan_resources = mv_xor_free_chan_resources;
     dma_dev->device_tx_status = mv_xor_status;
     dma_dev->device_issue_pending = mv_xor_issue_pending;
-    dma_dev->dev = &pdev->dev;

     /* set prep routines based on capability */
     if (dma_has_cap(DMA_INTERRUPT, dma_dev->cap_mask))
The patch is fine and it fixes the boot failure.

I misapplied it in previous test.

Thanks,
Dave

-- 
John David Anglin  dave.anglin@bell.net

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help