Re: [PATCH V3 4/5] dt-bindings: imx8-clock: add a53 and a72 clock id
From: Rob Herring <robh@kernel.org>
Date: 2019-02-13 22:18:18
Also in:
linux-clk, linux-devicetree
On Thu, Jan 24, 2019 at 01:22:45PM +0000, Aisheng Dong wrote:
quoted hunk ↗ jump to hunk
Add a53 and a72 clock id, as there's still no users, we update IMX_LSIO_MEM_CLK base to start from 6 to allow a53 and a72 clock id to be continued with a35 clk. Cc: Stephen Boyd <sboyd@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <redacted> Cc: Michael Turquette <mturquette@baylibre.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- v1->v2: * change cpu clock to cpu cluster clock per Rob's suggestion --- include/dt-bindings/clock/imx8-clock.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/include/dt-bindings/clock/imx8-clock.h b/include/dt-bindings/clock/imx8-clock.h index b149e63..dcce744 100644 --- a/include/dt-bindings/clock/imx8-clock.h +++ b/include/dt-bindings/clock/imx8-clock.h@@ -14,10 +14,12 @@ /* CPU */ #define IMX_A35_CLK 1 #define IMX_CPU_CLUSTER_A35_CLK 1 +#define IMX_CPU_CLUSTER_A53_CLK 2 +#define IMX_CPU_CLUSTER_A72_CLK 3
I still don't get this. How many clock outputs does the clock controller have for CPUs? If 3, then this is correct. If it's the same clock controller bits across different SoCs, then just name it something like IMX_CPU_CLUSTER_CLK and reuse the same ID.
/* LSIO SS */ -#define IMX_LSIO_MEM_CLK 2 -#define IMX_LSIO_BUS_CLK 3 +#define IMX_LSIO_MEM_CLK 6 +#define IMX_LSIO_BUS_CLK 7
Changing numbering is not good, but I guess it's early for imx8.
#define IMX_LSIO_PWM0_CLK 10 #define IMX_LSIO_PWM1_CLK 11 #define IMX_LSIO_PWM2_CLK 12 -- 2.7.4
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel