Re: [PATCH v2 04/12] ARM: davinci: WARN_ON() if clk_get() fails

wt., 5 lut 2019 o 03:18 David Lechner [off-list ref] napisał(a):

On 2/4/19 11:17 AM, Bartosz Golaszewski wrote:

quoted

From: Bartosz Golaszewski <redacted>

Currently the timer code checks if the clock pointer passed to it is
good (!IS_ERR(clk)). The new clocksource driver expects the clock to
be functional and doesn't perform any checks so emit a warning if
clk_get() fails. Apply this to all davinci platforms.

Signed-off-by: Bartosz Golaszewski <redacted>
---
  arch/arm/mach-davinci/da830.c  | 4 ++++
  arch/arm/mach-davinci/da850.c  | 4 ++++
  arch/arm/mach-davinci/dm355.c  | 4 ++++
  arch/arm/mach-davinci/dm365.c  | 4 ++++
  arch/arm/mach-davinci/dm644x.c | 4 ++++
  arch/arm/mach-davinci/dm646x.c | 4 ++++
  6 files changed, 24 insertions(+)

diff --git a/arch/arm/mach-davinci/da830.c b/arch/arm/mach-davinci/da830.c
index 2cc9fe4c3a91..9a4b749cbb6b 100644
--- a/arch/arm/mach-davinci/da830.c
+++ b/arch/arm/mach-davinci/da830.c

@@ -834,6 +834,10 @@ void __init da830_init_time(void)
      da830_pll_init(NULL, pll, NULL);

      clk = clk_get(NULL, "timer0");
+     if (WARN_ON(IS_ERR(clk))) {
+             pr_err("Unable to get the timer clock\n");

Do we really need a warning _and_ an error?

That will give us the reason AND point us to the right place in the code.

Bart

quoted

+             return;
+     }

      davinci_timer_init(clk);
  }

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel