Re: [PATCH 03/13] mm: Add generic p?d_large() macros

[PATCH 00/13] Convert x86 & arm64 to use generic page walk · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 01/13] arm64: mm: Add p?d_large() definitions · Steven Price <steven.price@arm.com> · 2019-02-15
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Mark Rutland <Mark.Rutland@arm.com> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Peter Zijlstra <peterz@infradead.org> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Steven Price <steven.price@arm.com> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Mark Rutland <mark.rutland@arm.com> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Peter Zijlstra <peterz@infradead.org> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Steven Price <steven.price@arm.com> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Mark Rutland <mark.rutland@arm.com> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Steven Price <steven.price@arm.com> · 2019-02-18
Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions · Mark Rutland <mark.rutland@arm.com> · 2019-02-18
[PATCH 02/13] x86/mm: Add p?d_large() definitions · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 03/13] mm: Add generic p?d_large() macros · Steven Price <steven.price@arm.com> · 2019-02-15
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Mark Rutland <Mark.Rutland@arm.com> · 2019-02-18
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Peter Zijlstra <peterz@infradead.org> · 2019-02-18
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Steven Price <steven.price@arm.com> · 2019-02-18
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Peter Zijlstra <peterz@infradead.org> · 2019-02-18
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Steven Price <steven.price@arm.com> · 2019-02-18
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Liang, Kan <hidden> · 2019-02-19
Re: [PATCH 03/13] mm: Add generic p?d_large() macros · Steven Price <steven.price@arm.com> · 2019-02-20
[PATCH 04/13] mm: pagewalk: Add p4d_entry() and pgd_entry() · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole · Steven Price <steven.price@arm.com> · 2019-02-15
Re: [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole · Mark Rutland <Mark.Rutland@arm.com> · 2019-02-18
Re: [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole · Steven Price <steven.price@arm.com> · 2019-02-18
Re: [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole · William Kucharski <hidden> · 2019-02-20
Re: [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole · Steven Price <steven.price@arm.com> · 2019-02-20
[PATCH 07/13] mm: pagewalk: Add test_p?d callbacks · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 08/13] arm64: mm: Convert mm/dump.c to use walk_page_range() · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 10/13] x86/mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 11/13] x86/mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 12/13] x86/mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range · Steven Price <steven.price@arm.com> · 2019-02-15
Re: [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range · Dave Hansen <hidden> · 2019-02-15
Re: [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 09/13] x86/mm: Point to struct seq_file from struct pg_state · Steven Price <steven.price@arm.com> · 2019-02-15
[PATCH 05/13] mm: pagewalk: Allow walking without vma · Steven Price <steven.price@arm.com> · 2019-02-15

From: Steven Price <steven.price@arm.com>
Date: 2019-02-18 14:20:37
Also in: linux-mm, lkml

On 18/02/2019 12:53, Peter Zijlstra wrote:

On Mon, Feb 18, 2019 at 11:14:23AM +0000, Mark Rutland wrote:

quoted

+#ifndef pgd_large
+#define pgd_large(x)0
+#endif
+#ifndef pud_large
+#define pud_large(x)0
+#endif
+#ifndef pmd_large
+#define pmd_large(x)0
+#endif

It might be worth a comment defining the semantics of these, e.g. how
they differ from p?d_huge() and p?d_trans_huge().

Yes; I took it to mean any large page mapping, so it would explicitly
include huge and thp.

Yes your interpretation is correct. I'll add a comment explaining the
semantics.

Thanks,

Steve


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help