RE: [PATCH V2 0/4] Add i.MX8QXP system controller watchdog support

Hi, Guenter

Best Regards!
Anson Huang

-----Original Message-----
From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter
Roeck
Sent: 2019年2月18日 13:16
To: Anson Huang <redacted>; robh+dt@kernel.org;
mark.rutland@arm.com; shawnguo@kernel.org; s.hauer@pengutronix.de;
kernel@pengutronix.de; festevam@gmail.com; catalin.marinas@arm.com;
will.deacon@arm.com; wim@linux-watchdog.org; Aisheng Dong
[off-list ref]; ulf.hansson@linaro.org; Daniel Baluta
[off-list ref]; Andy Gross [off-list ref];
horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de;
bjorn.andersson@linaro.org; jagan@amarulasolutions.com;
enric.balletbo@collabora.com; marc.w.gonzalez@free.fr; olof@lixom.net;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-watchdog@vger.kernel.org
Cc: dl-linux-imx <redacted>
Subject: Re: [PATCH V2 0/4] Add i.MX8QXP system controller watchdog
support

On 2/17/19 6:01 PM, Anson Huang wrote:

quoted

i.MX8QXP is an ARMv8 Cortex-A35 SoC with a Cortex-M4 system controller
inside, the system controller manages overall power, clock, secure RTC
and watchdog etc., so Linux kernel running on A35 needs to communicate
with system controller for watchdog operation, this system controller
watchdog will call SMC to trap to EL3 secure world
ARM-Trusted-Firmware and then it will request system controller to do the

watchdog operation via IPC.

quoted

And you expect I'll spend the time comparing this version of the patch series
against version 1 and figure out myself what exactly changed ?

Guenter

Sorry, I planned to reply your review mail but forgot, I addressed all your comments
in V2 patch set, I will add the change log in V2 watchdog driver patch and resend.

Anson.

Below are the patch dependency:

quoted

The dt-binding and imx8qxp.dtsi patch are based on my thermal patch

series as below:

quoted

https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat

quoted

chwork.kernel.org%2Fpatch%2F10800699%2F&data=02%7C01%7Canso
n.huang

quoted

%40nxp.com%7C630e6c5d7ed04a912f7708d695603cb2%7C686ea1d3bc2b4

c6fa92cd9

quoted

9c5c301635%7C0%7C0%7C636860637903984268&sdata=a25qJs%2Fb4e
2a9Ey77U

quoted

gTNKAGCQ8IWRcUKb4G0lK%2Bkjc%3D&reserved=0

Anson Huang (4):
   dt-bindings: fsl: scu: add watchdog binding
   watchdog: imx_sc: Add i.MX system controller watchdog support
   arm64: defconfig: add support for i.MX system controller watchdog
   arm64: dts: freescale: imx8qxp: add watchdog support

  .../devicetree/bindings/arm/freescale/fsl,scu.txt  |  10 +
  arch/arm64/boot/dts/freescale/imx8qxp.dtsi         |   4 +
  arch/arm64/configs/defconfig                       |   1 +
  drivers/watchdog/Kconfig                           |  13 ++
  drivers/watchdog/Makefile                          |   1 +
  drivers/watchdog/imx_sc_wdt.c                      | 210

+++++++++++++++++++++

quoted

  6 files changed, 239 insertions(+)
  create mode 100644 drivers/watchdog/imx_sc_wdt.c

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel