Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

From
Christoph Hellwig <hch@lst.de>
Date
2019-02-13 18:24:39
Also in
linux-devicetree, linux-iommu, linux-mips, linux-riscv, linux-sh, linuxppc-dev, lkml
Reply to
Rob Herring, 2019-02-12
On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote:
quoted
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 3607fd2810e4..f8c66a9472a4 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -43,6 +43,7 @@ config OF_FLATTREE

 config OF_EARLY_FLATTREE
        bool
+       select DMA_DECLARE_COHERENT
Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML.
No, that will fail with undefined references to memunmap.

I gues this needs to be

	select DMA_DECLARE_COHERENT if HAS_DMA
Maybe we should just get rid of OF_RESERVED_MEM. If we support booting
from DT, then it should always be enabled anyways.
Fine with me.  Do you want me to respin the series to just remove
it?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (27 messages) 27 messages, 5 authors, last reply 2019-02-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help