Re: [PATCH 0/4] Add new device nodes for Spreadtrum SC9860 platform
From: Mark Brown <broonie@kernel.org>
Date: 2019-02-12 12:20:46
Also in:
linux-devicetree, lkml
From: Mark Brown <broonie@kernel.org>
Date: 2019-02-12 12:20:46
Also in:
linux-devicetree, lkml
On Tue, Feb 12, 2019 at 04:40:10PM +0800, Baolin Wang wrote:
On Fri, 1 Feb 2019 at 21:05, Mark Brown [off-list ref] wrote:
quoted
You can just list all the individual device names in the of_match_table for the MFD and then it can bind to any of them. You can always map them onto the same behaviour in the MFD driver if they are identical from a software point of view.
If I understood correctly, as you suggested, we should add new mfd_cell groups to list all different PMICs' device names. Something like:
I do think this is a good idea (registering the components of the MFD using mfd_cell), though it wasn't quite the point I was making. Having individual device names matters less for Linux-internal names like this.
But from my point, they are just some meaningless duplication, and will waste lots of code there.
I was more thinking of the of_match table that has the IDs that appear in DT - they're the one that's the ABI. Look at something like wm8994 where the driver has several IDs listed in the main table then selects function drivers based on that.