Re: [PATCH net-next v2 01/10] net: phy: Update PHY linkmodes after config_init

On 07.02.2019 14:55, Maxime Chevallier wrote:

Hello Andrew,

On Thu, 7 Feb 2019 14:48:07 +0100
Andrew Lunn [off-list ref] wrote:

quoted

On Thu, Feb 07, 2019 at 10:49:30AM +0100, Maxime Chevallier wrote:

quoted

We want to be able to update a PHY's supported list in the config_init
callback, so move the Pause parameters settings from phydrv->features
after calling config_init to make sure these  parameters aren't
overwritten.  

Hi Maxime

I have a patch which makes some core changes to support PHY doing
runtime feature detection. I would prefer to use them, than this.

Either I or Heiner will post them soon.

Sure, no problem, thanks for doing this. I'll be happy to review and
test that on my side.

The second version of the patch set comes in time because I was just
about to submit parts of it on Maxime's behalf. We may have some
dependencies between adding the get_features callback in phy_driver
and this patch set. Maybe the patch set needs to be splitted.
I think tomorrow or the day after I can have a closer look at this.

As I said, I lack the big picture view on that part so my approach was
pretty naive, I'm glad you can take care of this :)

Don't be so self-effacing, it's good work :)

Thanks,

Maxime

Heiner

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel