Thread (19 messages) 19 messages, 8 authors, 2019-02-05

Re: [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels

From: Nicolas Dechesne <hidden>
Date: 2019-02-05 19:01:00
Also in: linux-arm-msm, linux-devicetree, linux-leds, linux-rockchip, lkml

Hey Mani,

thanks for sending this out, it should have been just like that in the
first place ;)

On Fri, Dec 21, 2018 at 3:36 AM Manivannan Sadhasivam
[off-list ref] wrote:
On Mon, Oct 29, 2018 at 03:12:45PM +0530, Manivannan Sadhasivam wrote:
quoted
For all 96Boards, the following standard is used for onboard LEDs.

green:user1  default-trigger: heartbeat
green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
green:user3  default-trigger: mmc1 (SD-card)
green:user4  default-trigger: none, panic-indicator
yellow:wlan  default-trigger: phy0tx
blue:bt      default-trigger: hci0-power

So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
one of the 96Boards CE platform.
Hello,

Any update on this patch?
Reviewed-by: Nicolas Dechesne <redacted>
Regards,
Mani
quoted
Signed-off-by: Manivannan Sadhasivam <redacted>
Acked-by: Amit Kucheria <redacted>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 46feedf7c989..35f95154316b 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -300,28 +300,28 @@
                      compatible = "gpio-leds";

                      led@1 {
-                             label = "apq8016-sbc:green:user1";
+                             label = "green:user1";
                              gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
                              linux,default-trigger = "heartbeat";
                              default-state = "off";
                      };

                      led@2 {
-                             label = "apq8016-sbc:green:user2";
+                             label = "green:user2";
                              gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
                              linux,default-trigger = "mmc0";
                              default-state = "off";
                      };

                      led@3 {
-                             label = "apq8016-sbc:green:user3";
+                             label = "green:user3";
                              gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
                              linux,default-trigger = "mmc1";
                              default-state = "off";
                      };

                      led@4 {
-                             label = "apq8016-sbc:green:user4";
+                             label = "green:user4";
                              gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
                              linux,default-trigger = "none";
                              panic-indicator;
@@ -329,14 +329,14 @@
                      };

                      led@5 {
-                             label = "apq8016-sbc:yellow:wlan";
+                             label = "yellow:wlan";
                              gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
                              linux,default-trigger = "phy0tx";
                              default-state = "off";
                      };

                      led@6 {
-                             label = "apq8016-sbc:blue:bt";
+                             label = "blue:bt";
                              gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
                              linux,default-trigger = "bluetooth-power";
                              default-state = "off";
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help