-----Original Message-----
From: Shawn Guo [mailto:shawnguo@kernel.org]
Sent: Friday, February 1, 2019 8:24 AM
To: Yogesh Narayan Gaur <redacted>
Cc: linux-mtd@lists.infradead.org; bbrezillon@kernel.org;
marek.vasut@gmail.com; broonie@kernel.org; linux-spi@vger.kernel.org;
devicetree@vger.kernel.org; mark.rutland@arm.com; robh@kernel.org; linux-
kernel@vger.kernel.org; frieder.schrempf@kontron.de;
computersforpeace@gmail.com; linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

On Tue, Jan 15, 2019 at 12:00:26PM +0000, Yogesh Narayan Gaur wrote:

quoted

Add fspi node property for LX2160A SoC for FlexSPI driver.
Property added for the FlexSPI controller and for the connected slave
device for the LX2160ARDB target.
This is having two SPI-NOR flash device, mt35xu512aba, connected at
CS0 and CS1.

Signed-off-by: Yogesh Narayan Gaur <redacted>
---
Changes for v8:
- None
Changes for v7:
- None
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- Incorporated Rob review comments.
Changes for v3:
- None.
Changes for v2:
- Incorporated Shawn review comments.

 .../boot/dts/freescale/fsl-lx2160a-rdb.dts    | 22 +++++++++++++++++++
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 13 +++++++++++
 2 files changed, 35 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts

b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index 6481e5f20e69..70658946fbbe 100644

--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts

@@ -50,6 +50,28 @@
 	status = "okay";
 };

+&fspi {
+	status = "okay";
+
+	mt35xu512aba0: flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;
+	};
+
+	mt35xu512aba1: flash@1 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spansion,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <1>;
+	};
+};
+
 &i2c0 {
 	status = "okay";

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi

b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index a79f5c1ea56d..e3ff86201f73 100644

--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi

@@ -762,5 +762,18 @@
 				     <GIC_SPI 209 IRQ_TYPE_LEVEL_HIGH>;
 			dma-coherent;
 		};
+
+		fspi: spi@20c0000 {

To keep the nodes sorted in unit-address, it should go after i2c@2070000.

quoted

+			compatible = "nxp,lx2160a-fspi";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x20c0000 0x0 0x10000>,
+				<0x0 0x20000000 0x0 0x10000000>;

I would align the indentation with the above.

quoted

+			reg-names = "fspi_base", "fspi_mmap";
+			interrupts = <0 25 0x4>; /* Level high type */

interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; so that we can save the
comment there.

I fixed up all these small things and applied the patch.

Ok, Thanks.

--
Regards
Yogesh Gaur.

Shawn

quoted

+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "fspi_en", "fspi";
+			status = "disabled";
+		};
 	};
 };
--
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
s.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-

kernel&data=02%7C

quoted

01%7Cyogeshnarayan.gaur%40nxp.com%7C6308464db1a541247dfd08d687f09
124%7

quoted

C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636845864632818753&a
mp;sda

quoted

ta=urGFUKDP6ZZZOTXS1ccfLceCV2OBV5%2BiZq9foCu7ZX8%3D&reserved=
0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel