Hi Krzysztof,

On 1/29/19 4:13 PM, Krzysztof Kozlowski wrote:

On Mon, 28 Jan 2019 at 20:21, Lukasz Luba [off-list ref] wrote:

quoted

Add description of Dynamic Memory Controller and PPMU counters.
They are used by exynos5-dmc driver.

CC: Rob Herring <robh+dt@kernel.org>
CC: Mark Rutland <mark.rutland@arm.com>
CC: Kukjin Kim <kgene@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: devicetree@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-samsung-soc@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Lukasz Luba <redacted>
---
  arch/arm/boot/dts/exynos5420.dtsi             | 81 +++++++++++++++++++++++++++
  arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 22 ++++++++
  2 files changed, 103 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index aaff158..6880d13 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi

@@ -1337,6 +1337,87 @@
                                 opp-hz = /bits/ 64 <400000000>;
                         };
                 };
+
+               ppmu_dmc0_0: ppmu_dmc0_0@10d00000 {
+                       compatible = "samsung,exynos-ppmu";
+                       reg = <0x10d00000 0x2000>;
+                       clocks = <&clock CLK_PCLK_PPMU_DREX0_0>;
+                       clock-names = "ppmu";
+                       events {
+                               ppmu_event_dmc0_0: ppmu-event3-dmc0_0 {
+                                       event-name = "ppmu-event3-dmc0_0";
+                               };
+                       };
+               };
+
+

No need for double line.

Agree

quoted

+               ppmu_dmc0_1: ppmu_dmc0_1@10d10000 {
+                       compatible = "samsung,exynos-ppmu";
+                       reg = <0x10d10000 0x2000>;
+                       clocks = <&clock CLK_PCLK_PPMU_DREX0_1>;
+                       clock-names = "ppmu";
+                       events {
+                               ppmu_event_dmc0_1: ppmu-event3-dmc0_1 {
+                                       event-name = "ppmu-event3-dmc0_1";
+                               };
+                       };
+               };
+
+               ppmu_dmc1_0: ppmu_dmc1_0@10d10000 {
+                       compatible = "samsung,exynos-ppmu";
+                       reg = <0x10d60000 0x2000>;
+                       clocks = <&clock CLK_PCLK_PPMU_DREX1_0>;
+                       clock-names = "ppmu";
+                       events {
+                               ppmu_event_dmc1_0: ppmu-event3-dmc1_0 {
+                                       event-name = "ppmu-event3-dmc1_0";
+                               };
+                       };
+               };
+
+               ppmu_dmc1_1: ppmu_dmc1_1@10d70000 {

1. Generic node name, e.g. "ppmu".
2. Please put all ppmu nodes after nocp nodes to group everything logically.

OK

quoted

+                       compatible = "samsung,exynos-ppmu";
+                       reg = <0x10d70000 0x2000>;
+                       clocks = <&clock CLK_PCLK_PPMU_DREX1_1>;
+                       clock-names = "ppmu";
+                       events {
+                               ppmu_event_dmc1_1: ppmu-event3-dmc1_1 {
+                                       event-name = "ppmu-event3-dmc1_1";
+                               };
+                       };
+               };
+
+               dmc: dmc@10c20000 {

1. Node name: memory-controller.
2. Put it before nocp nodes.

OK

quoted

+                       compatible = "samsung,exynos5422-dmc";
+                       reg = <0x10c20000 0x10000>, <0x10c30000 0x10000>,
+                               <0x10030000 0x1000>, <0x10000000 0x1000>;
+                       clocks =        <&clock CLK_FOUT_SPLL>,

Weird indentation.

quoted

+                                       <&clock CLK_MOUT_SCLK_SPLL>,
+                                       <&clock CLK_FF_DOUT_SPLL2>,

Indent all continued lines with first entry (like in other places in this file)

quoted

+                                       <&clock CLK_FOUT_BPLL>,
+                                       <&clock CLK_MOUT_BPLL>,
+                                       <&clock CLK_SCLK_BPLL>,
+                                       <&clock CLK_MOUT_MX_MSPLL_CCORE>,
+                                       <&clock CLK_MOUT_MX_MSPLL_CCORE_PHY>,
+                                       <&clock CLK_MOUT_MCLK_CDREX>,
+                                       <&clock CLK_DOUT_CLK2X_PHY0>,
+                                       <&clock CLK_CLKM_PHY0>,
+                                       <&clock CLK_CLKM_PHY1>
+                                       ;

Join the trailing semicolon with previous lines.

OK

quoted

+                       clock-names =   "fout_spll",
+                                       "mout_sclk_spll",

Indent all continued lines with first entry (like in other places in this file).

OK and all the entries will be compacted where possible for 80lines.

quoted

+                                       "ff_dout_spll2",
+                                       "fout_bpll",
+                                       "mout_bpll",
+                                       "sclk_bpll",
+                                       "mout_mx_mspll_ccore",
+                                       "mout_mx_mspll_ccore_phy",
+                                       "mout_mclk_cdrex",
+                                       "dout_clk2x_phy0",
+                                       "clkm_phy0",
+                                       "clkm_phy1"
+                                       ;

Join the trailing semicolon with previous lines.

quoted

+               };
         };

         thermal-zones {

diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
index bf09eab..54ee8b2 100644
--- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi

@@ -119,6 +119,28 @@
         status = "okay";
  };

+&ppmu_dmc0_0 {
+       status = "okay";
+};
+
+&ppmu_dmc0_1 {
+       status = "okay";
+};
+
+&ppmu_dmc1_0 {
+       status = "okay";
+};
+
+&ppmu_dmc1_1 {
+       status = "okay";
+};

Put the new entries respecting alphabetical order (order of label name).

OK

quoted

+
+&dmc {

The same.

Thank you for review, in v2 it will be fixed.

Regards,
Lukasz

Best regards,
Krzysztof

quoted

+       devfreq-events = <&ppmu_dmc0_0>, <&ppmu_dmc0_1>,
+                       <&ppmu_dmc1_0>, <&ppmu_dmc1_1>;
+       status = "okay";
+};
+
  &cpu0 {
         cpu-supply = <&buck6_reg>;
  };
--
2.7.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel