On Tue, 2019-01-29 at 10:16 +0100, Guido Günther wrote:

Hi,
On Mon, Jan 28, 2019 at 07:24:33PM +0100, Bastien Nocera wrote:

quoted

On Mon, 2019-01-28 at 18:03 +0100, Guido Günther wrote:

quoted

From what I've seen in vendor trees it's fine to treat this as
gt1x¹.

[1]: 
https://github.com/TadiT7/android_kernel_mtk-4.4/tree/master/drivers/input/touchscreen/mediatek/GT5688

Can you please point to the exact line of code that makes you say
that?
I'm not saying it's not compatible, but it's not the same driver
that
the current goodix.c was based on, or even goodix.c.

Can you please elaborate?

I basically looked at the registers uses for the config update:

https://github.com/TadiT7/android_kernel_mtk-4.4/blob/master/drivers/input/touchscreen/mediatek/GT5688/include/gt1x_tpd_common.h#L152
https://github.com/TadiT7/android_kernel_mtk-4.4/blob/master/drivers/input/touchscreen/mediatek/GT5688/gt1x_generic.c#L430

I'm not sure that's good enough to say that the touchscreen models are
compatible.

That and the fact that the driver is doing it's job well made me
believe
that's good for base support.

If you've tested it, that's better. Can you please add a reference to
the device that you've tested this on in the commit message?

 Things like hotknot, gesture wakeup and
proximity sensor will need additional work.

quoted

Finding that data in the specs would also be fine:
https://github.com/hadess/gt9xx/tree/master/specifications

https://github.com/hadess/gt9xx/pull/3

Merged that, thanks

Cheers


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel